Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken overallocation validation in payment entry (backport #36181) #36184

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix: broken overallocation validation in payment entry (backport #36181) #36184

merged 2 commits into from
Jul 19, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2023

This is an automatic backport of pull request #36181 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ruthra-kumar @mergify
fix: broken overallocation validation in payment entry
e1d31aa 
In a multi term payment schedule, overallocation logic broke. Fixing
it using individual term outstanding amount in references. this should
work for the simple, one term payment schedule as well

(cherry picked from commit f8d4b19)
@ruthra-kumar @mergify
refactor: payment term outstanding in party account currency
fcafff7 
(cherry picked from commit ee83f94)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 19, 2023
@ruthra-kumar ruthra-kumar merged commit 61456ec into version-14-hotfix Jul 19, 2023
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-36181 branch July 19, 2023 05:41
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees

@ruthra-kumar ruthra-kumar

Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frappe-pr-bot @ruthra-kumar